qemu: use 2048 MiB on all architectures#4467
Merged
dustymabe merged 1 commit intocoreos:mainfrom Mar 10, 2026
Merged
Conversation
The alternatives test is now failing because rpm-ostree gets OOM killed because we're now including the coreos-pool repo when layering iptables-legacy [1]. Let's just move x86_64 to the default of 2048 that we're using everywhere else too. [1] coreos/fedora-coreos-config#4038
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request sets a uniform QEMU memory default of 2048 MiB for all architectures to resolve an out-of-memory issue. I've added one suggestion to document the new default value. As a follow-up, consider updating the comment for MemoryMiB in the QemuBuilder struct (line 494), which is now outdated.
Note: Security Review did not run due to the size of the PR.
|
LGTM too, FWIW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alternatives test is now failing because rpm-ostree gets OOM killed because we're now including the coreos-pool repo when layering iptables-legacy [1].
Let's just move x86_64 to the default of 2048 that we're using everywhere else too.
[1] coreos/fedora-coreos-config#4038