Add the test cases for iterator verification(Range, FixedFilter)#54
Merged
coeff-aij merged 1 commit intocoord-e:mainfrom Mar 9, 2026
Merged
Add the test cases for iterator verification(Range, FixedFilter)#54coeff-aij merged 1 commit intocoord-e:mainfrom
coeff-aij merged 1 commit intocoord-e:mainfrom
Conversation
coeff-aij
changed the title
coeff-aij
changed the title
coeff-aij
force-pushed
the
iterator-verification
branch
from
4cfdf00 to
fbbc760
Compare
coord-e
reviewed
Mar 7, 2026
Owner
coord-e
left a comment
coord-e
left a comment
There was a problem hiding this comment.
Can you add some tests/ui/fail/ cases by simply changing the assertions to falsy ones as a simple sanity check to ensure we haven't run into any unsoundness?
tests/ui/pass/iterators/range.rs
Outdated
|
|
||
| assert!(count == 5); | ||
| assert!(range.start == count); | ||
| } No newline at end of file |
coeff-aij
force-pushed
the
iterator-verification
branch
from
fbbc760 to
b7cd967
Compare
Collaborator
Author
|
I've added negative tests and trailing newline. And I also removed unnecessary |
coord-e
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Thrust can support verification for iterators without generics. This PR extends the test suite to include:
Rangeiterator: Verification of a call tonext()and a simplewhile letloop.FixedFilteradapter: A non-generic version of theFilteradapter where type parameters and the Boolean functionpredicateare hard-coded.