Add optional FAKTORY_WEBUI_PASSWORD with argon2id, bcrypt, scrypt, and PBKDF2 support#511
Open
f3ndot wants to merge 11 commits into
Open
Add optional FAKTORY_WEBUI_PASSWORD with argon2id, bcrypt, scrypt, and PBKDF2 support#511f3ndot wants to merge 11 commits into
FAKTORY_WEBUI_PASSWORD with argon2id, bcrypt, scrypt, and PBKDF2 support#511f3ndot wants to merge 11 commits into
Conversation
Collaborator
|
Looks like some CI failures? |
Collaborator
|
Code looks great and nice PR writeup. Well done. |
f3ndot
commented
Jun 11, 2025
Author
|
@mperham should be good for another CI run and ready for merge at your convenience. Needed a |
Collaborator
|
I'm not a fan of creating a new |
Author
|
Makes sense to me. Once I did that, I had a random memory usage test fail in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
New functionality:
FAKTORY_WEBUI_PASSWORDcan be specified. If set, it will configure the Web UI with that password otherwise will fallback toFAKTORY_PASSWORDvalue. This is the existing behaviour for the undocumented TOML config[web]subsystem'spasswordelement.Rationale:
/etc/shadowafter all these years. It's considered the de facto standard for representing password hashes in a non-standardized world of password hashing. It's what's used by Argon2 and the likes. Popular hashing libraries like Python's passlib use it and should come as no surprise to developers using Faktory.golang.org/x/cryptomodule, so we can trust the implementations are cryptographically correct.Interface:
There is a new
passwordmodule withfunc Verify(candidate string, configured string) (bool, error). This is what will allow detection of password hashing algos and match accordingly (or fallback to plaintext).