feat: add accept method (supersedes #292)#314
Open
KarstenB wants to merge 1 commit into
Open
Conversation
Add accept method for better error handling and ergononics when only one connection is expected. Fixes containerd#293 Signed-off-by: Karsten Becker <567973+KarstenB@users.noreply.github.com> Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
Closed
shvbsle
reviewed
May 19, 2026
| pub async fn accept(&self, conn: Socket) -> std::io::Result<()> { | ||
| let delegate = ServerBuilder { | ||
| services: self.services.clone(), | ||
| streams: Arc::default(), |
Contributor
There was a problem hiding this comment.
style nit: spawn_connection_handler initializes the streams as
streams: Arc::new(Mutex::new(HashMap::new())), so you could consider doing the same here.
| Ok(()) | ||
| } | ||
|
|
||
| pub async fn accept(&self, conn: Socket) -> std::io::Result<()> { |
Contributor
There was a problem hiding this comment.
The crate defines it's own error type in here:
https://github.com/containerd/ttrpc-rust/blob/master/src/error.rs#L66
Every other public method on Server returns this crate-level Result<()> so can we use this instead?
From a consumer's perspective, if you're using this server and calling multiple methods, you'd expect a consistent error type.
Suggested change
| pub async fn accept(&self, conn: Socket) -> std::io::Result<()> { | |
| pub async fn accept(&self, conn: Socket) -> Result<()> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add accept method for better error handling and ergononics when only one connection is expected. Fixes #293
I didn't want to force push on a branch that is already used externally, but this branch removes the
&mut selfin favor of a&self.