Open
Conversation
Contributor
Code Review by QodoLooking for bugs?Come back again in a few minutes. An AI review agent is analysing this pull request
|
simonbaird
reviewed
Mar 3, 2026
.tekton/cli-main-pull-request.yaml
Outdated
| value: tkn-bundle-oci-ta | ||
| - name: bundle | ||
| value: quay.io/konflux-ci/tekton-catalog/task-tkn-bundle-oci-ta:0.2@sha256:356a021208054be1b9bf7083b4532b8466832f51490abb0d0519dde4e163e764 | ||
| value: quay.io/konflux-ci/tekton-catalog/task-tkn-bundle-oci-ta@sha256:0e12654b0532ca720523693a5a85e67e0221d3678e2f54c675a61e72c5c240b3 |
Member
There was a problem hiding this comment.
I think we need to keep the tag like this:
Suggested change
| value: quay.io/konflux-ci/tekton-catalog/task-tkn-bundle-oci-ta@sha256:0e12654b0532ca720523693a5a85e67e0221d3678e2f54c675a61e72c5c240b3 | |
| value: quay.io/konflux-ci/tekton-catalog/task-tkn-bundle-oci-ta:0.2@sha256:0e12654b0532ca720523693a5a85e67e0221d3678e2f54c675a61e72c5c240b3 |
Member
There was a problem hiding this comment.
I didn't see the change, so leaving unresolved..?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
simonbaird
reviewed
Mar 3, 2026
.tekton/cli-main-push.yaml
Outdated
| - name: bundle | ||
| value: quay.io/konflux-ci/tekton-catalog/task-tkn-bundle-oci-ta:0.2@sha256:356a021208054be1b9bf7083b4532b8466832f51490abb0d0519dde4e163e764 | ||
| - name: kind | ||
| value: quay.io/konflux-ci/tekton-catalog/task-tkn-bundle-oci-ta@sha256:0e12654b0532ca720523693a5a85e67e0221d3678e2f54c675a61e72c5c240b3 |
Contributor
Author
There was a problem hiding this comment.
We replace each image reference with an updated cli image. When doing that we need to exlcude the trusted artifacts image. https://issues.redhat.com/browse/EC-1685
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace each image reference with an updated cli image. When doing that we need to exlcude the
trusted artifacts image.
https://issues.redhat.com/browse/EC-1685