Open
Conversation
Reversean
force-pushed
the
refactor/user-manager
branch
2 times, most recently
from
37eecbd to
70760fd
Compare
Reversean
force-pushed
the
chore/core-workspace
branch
2 times, most recently
from
09b7782 to
39d9d88
Compare
Reversean
force-pushed
the
refactor/user-manager
branch
from
70760fd to
3f9a33a
Compare
Reversean
force-pushed
the
refactor/user-manager
branch
4 times, most recently
from
a0132ff to
9a60f23
Compare
Reversean
changed the base branch from
chore/core-workspace
to
chore/browser-workspace
Reversean
changed the base branch from
chore/browser-workspace
to
refactor/hawk-storage
Reversean
force-pushed
the
refactor/hawk-storage
branch
from
9e471fc to
2d655c1
Compare
Reversean
force-pushed
the
refactor/user-manager
branch
from
9a60f23 to
eacefe1
Compare
Reversean
force-pushed
the
refactor/hawk-storage
branch
2 times, most recently
from
c3013b6 to
223001d
Compare
Reversean
force-pushed
the
refactor/user-manager
branch
from
eacefe1 to
7d5e8e4
Compare
neSpecc
reviewed
Feb 17, 2026
There was a problem hiding this comment.
Pull request overview
This PR introduces a UserManager abstraction in @hawk.so/core to enable environment-agnostic user persistence, as part of the larger effort to extract shared logic from @hawk.so/javascript into a core package (related to issue #151).
Changes:
- Added
UserManagerinterface andHawkStorageUserManagerimplementation in@hawk.so/corefor environment-agnostic user management - Refactored
@hawk.so/javascriptto use the newUserManagerabstraction instead of directly accessing localStorage - Modified user initialization to be lazy (generated on first access) rather than eager (generated in constructor)
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/users/user-manager.ts | New interface defining the user management contract |
| packages/core/src/users/hawk-storage-user-manager.ts | Implementation of UserManager using HawkStorage for persistence |
| packages/core/src/index.ts | Exports new UserManager interface and implementation |
| packages/core/tests/users/hawk-storage-user-manager.test.ts | Unit tests for HawkStorageUserManager |
| packages/core/package.json | Added test scripts and dev dependencies for vitest |
| packages/core/vitest.config.ts | New vitest configuration for core package |
| packages/core/tsconfig.test.json | TypeScript config for test files |
| packages/javascript/src/catcher.ts | Refactored to use UserManager, removed getGeneratedUser, changed user initialization to lazy |
| packages/javascript/src/storages/hawk-local-storage.ts | Browser-specific implementation of HawkStorage |
| packages/javascript/package.json | Added @hawk.so/core as dependency |
| packages/javascript/vite.config.ts | Marked @hawk.so/core as external dependency |
| packages/javascript/vitest.config.ts | Added source condition for workspace dependency resolution |
| yarn.lock | Updated workspace dependency configurations |
| package.json | Added test:all and test:modified scripts for workspace testing |
| .github/workflows/main.yml | Updated test workflow to run tests on modified packages with fetch-depth: 0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reversean
force-pushed
the
refactor/hawk-storage
branch
2 times, most recently
from
8cbdac2 to
cd47f1e
Compare
Reversean
force-pushed
the
refactor/user-manager
branch
2 times, most recently
from
fb57118 to
77fb17d
Compare
Reversean
force-pushed
the
refactor/hawk-storage
branch
from
cd47f1e to
7c1ad96
Compare
Reversean
force-pushed
the
refactor/user-manager
branch
from
77fb17d to
7c596c5
Compare
Reversean
force-pushed
the
refactor/hawk-storage
branch
from
7c1ad96 to
591724a
Compare
Reversean
force-pushed
the
refactor/user-manager
branch
from
7c596c5 to
d0c4bff
Compare
FeironoX5
approved these changes
Feb 26, 2026
Reversean
force-pushed
the
refactor/hawk-storage
branch
from
591724a to
a2abcb9
Compare
Reversean
force-pushed
the
refactor/user-manager
branch
from
798f237 to
88436ca
Compare
neSpecc
reviewed
Mar 5, 2026
| /** | ||
| * Storage key used to persist the auto-generated user ID. | ||
| */ | ||
| export const SESSION_STORAGE_KEY = 'hawk-user-id'; |
Member
Author
There was a problem hiding this comment.
Originally there was HAWK_USER_ID_KEY.
@FeironoX5, you've changed the name? Any comments?
Reversean
force-pushed
the
refactor/user-manager
branch
from
48d0fcd to
f727fc0
Compare
neSpecc
approved these changes
Mar 7, 2026
- user management logic moved from Catcher (@hawk.so/javascript) to HawkUserManager (@hawk.so/core) - added RandomGenerator to provide random-generation utilities - utility method `id` moved from @hawk.so/javascript to @hawk.so/core
Reversean
force-pushed
the
refactor/user-manager
branch
from
f727fc0 to
cacf090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #151
Added
UserManagerinterface which could be used as env-agnositc abstraction to persistAffectedUser's during catching errors.Also
StorageUserManagerimplementation based on env-agnosticHawkStorageadded.