Improve output in interactive mode#3884
Open
darkmattercoder wants to merge 2 commits intocodespell-project:mainfrom
Open
Improve output in interactive mode#3884darkmattercoder wants to merge 2 commits intocodespell-project:mainfrom
darkmattercoder wants to merge 2 commits intocodespell-project:mainfrom
Conversation
When in interactive mode, the file name and line number is now printed before the User is asked for confirmation. Also the filename color is applied in the `FIXED: ` printout. Fix codespell-project#1925
Author
|
Am I supposed to to something about the failing checks? Especially the decrease in coverage, which imho mainly originates from added line breaks. I still do not know why some of the pytests fail. It looks as if that were due to some dependency issue. They ran successfully on main a few days ago, and I did not do anything regarding dependencies in my commits, so I am a bit clueless here atm. |
Member
|
Should be fixed by #3886 which I just merged into your branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in interactive mode, the file name and
line number is now printed before the User
is asked for confirmation.
This adds context to the suggestion. Before, the file was only displayed after the change had been applied.
Also the filename color is applied in the
FIXED:printout.Fix #1925
See: