🤖 fix: change Electron appId to com.coder.mux#2586
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6c2168926
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ], | ||
| "build": { | ||
| "appId": "com.mux.app", | ||
| "appId": "com.coder.mux", |
There was a problem hiding this comment.
Keep Electron appId stable across released builds
Changing build.appId changes the OS-level application identity (bundle ID/AUMID), so users already installed under com.mux.app can lose seamless in-place upgrade behavior and may end up with parallel installs or broken update continuity on macOS/Windows. This commit updates the identifier but does not include any migration strategy, so existing production installs are at risk during the next upgrade.
Useful? React with 👍 / 👎.
|
Thanks for the callout. This appId change is intentional in this PR, and I’ve marked it as potentially breaking in the PR body. I agree this can break in-place update continuity for users already installed under Given that migration across OS-level app identity is a release/product decision (not a simple code-only fix), I’m pausing for maintainer direction on whether we should:
|
Summary
Change the Electron Builder application identifier from
com.mux.apptocom.coder.mux.Background
The current app ID uses the legacy
com.mux.appidentifier. This PR updates branding alignment tocom.coder.mux.Implementation
build.appIdinpackage.json:com.mux.app→com.coder.muxValidation
make static-checkRisks
Potentially breaking for existing installs. Changing Electron Builder
appIdcan affect OS-level app identity and update continuity:CFBundleIdentifier)Existing installations that were distributed with
com.mux.appmay require reinstall/migration handling instead of seamless in-place updates.Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.28