fix: skip ENOENT errors during home/workspace directory chown walk#498
Merged
fix: skip ENOENT errors during home/workspace directory chown walk#498
Conversation
Fixes #489. When background processes create and delete temporary files during filepath.Walk, the walk receives ENOENT and aborts entirely, leaving directories in a partially-owned state. Now both the workspace folder and home directory chown walks skip fs.ErrNotExist errors, allowing the walk to continue chowning remaining files even when individual files disappear mid-operation.
johnstcn
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #489.
When background processes create and delete temporary files during
filepath.Walk, the walk receives ENOENT and aborts entirely, leaving directories in a partially-owned state.Now both the workspace folder and home directory chown walks skip
fs.ErrNotExisterrors, allowing the walk to continue chowning remaining files even when individual files disappear mid-operation.