Make InteractionDialog popup bias configurable and deterministic (prefer top/right)

[liannacasper]

Motivation

• Allow callers to express a preference for showing the popup above/right of the target when both sides fit, and make the placement deterministic when both sides are available.

Description

• Rename the bias parameter to prioritizeTopOrRightPosition on showPopupDialog and update its documentation to explain the top/right preference semantics and fallback behavior.
• Replace ad-hoc orientation checks with explicit available-space calculations (spaceAbove, spaceBelow, spaceRight, spaceLeft) and determine showAbove / showRight by combining the preference with whether each side fits.
• Keep the device orientation-based showPortrait decision but stop using the old bias flag for that purpose and propagate the new parameter to the internal showPopupDialog overload.
• Add unit tests in InteractionDialogTest to verify preferred placement when both sides fit, fallback behavior when the preferred side doesn't fit, and the inverse preference.
• Add an interactive screenshot test InteractionDialogPopupBiasScreenshotTest and register it in the device runner so the bias behavior is validated in the screenshot suite.

Testing

• Ran the Maven core unit tests (including the new InteractionDialogTest cases) via the CI unit test profile and they passed.
• Ran the CN1SS screenshot suite with the new InteractionDialogPopupBiasScreenshotTest included and the screenshot run completed successfully.

---

Codex Task

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2366 total, 0 failed, 0 skipped
• 📊 Line coverage: 53.33% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.util.EasyThread$InQueueRunnable – 0.00%
    • com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
    • com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
    • com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
    • com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
    • com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
    • com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
    • com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

• SpotBugs [HTML preview] [Download]
  • ❌ ByteCodeTranslator: 109 findings (High: 2, Normal: 80, Low: 27)
    • Top findings
      • High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
      • High: com/codename1/tools/translator/bytecodes/TryCatch.java:91 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • Normal: com/codename1/tools/translator/ByteCodeClass.java:1802 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
      • …and 106 more
  • ❌ android: 413 findings (High: 24, Normal: 196, Low: 193)
    • Top findings
      • High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/android/AndroidImplementation.java:1085 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • High: com/codename1/impl/android/AndroidImplementation.java:1286 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • …and 410 more
  • ❌ codenameone-maven-plugin: 488 findings (High: 1, Normal: 315, Low: 172)
    • Top findings
      • High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
      • …and 485 more
  • ❌ core-unittests: 1 findings (Normal: 1)
    • Top findings
      • Normal: CodenameOne/src/com/codename1/ui/util/MutableResource.java:239 – com.codename1.ui.util.MutableResource.saveL10N(DataOutputStream, Hashtable) makes inefficient use of keySet iterator instead of entrySet iterator (rule: WMI_WRONG_MAP_ITERATOR)
  • ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
    • Top findings
      • High: com/codename1/impl/ios/IOSImplementation.java:1228 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • …and 122 more
• ✅ PMD: 0 findings (no issues) [Report archive]
• ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

[shai-almog]

Android screenshot updates

Compared 34 screenshots: 33 matched, 1 missing reference.

• InteractionDialogPopupBias — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/InteractionDialogPopupBias.png.

  
  Preview info: JPEG preview quality 70; JPEG preview quality 70.
  Full-resolution PNG saved as InteractionDialogPopupBias.png in workflow artifacts.

Native Android coverage

• 📊 Line coverage: 7.66% (3914/51088 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 6.05% (19416/321122), branch 2.84% (885/31169), complexity 3.57% (1064/29822), method 6.29% (875/13906), class 10.40% (192/1846)
  • Lowest covered classes
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
    • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
    • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
    • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
    • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
    • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

[shai-almog]

iOS screenshot updates

Compared 34 screenshots: 32 matched, 1 updated, 1 missing reference.

• InteractionDialogPopupBias — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/InteractionDialogPopupBias.png.

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as InteractionDialogPopupBias.png in workflow artifacts.

• landscape — updated screenshot. Screenshot differs (2556x1179 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as landscape.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 0 seconds
• Compilation Time: 168 seconds

Detailed Performance Metrics

Metric	Duration
Simulator Boot	65000 ms
Simulator Boot (Run)	1000 ms
App Install	11000 ms
App Launch	6000 ms
Test Execution	142000 ms