Removed follow and unfollow bill and user#2075
Open
AstorDG wants to merge 4 commits intocodeforboston:mainfrom
Open
Removed follow and unfollow bill and user#2075AstorDG wants to merge 4 commits intocodeforboston:mainfrom
AstorDG wants to merge 4 commits intocodeforboston:mainfrom
Conversation
…inResolveReport Created v2 versions of all of these functions that are firebase v2 versions. I also created v2 versions of checkAuth and checkAdmin and the fail function they use for throwing errors that use the v2 error type.
…rNotificationFrequency to firebase v2
Removed the imports for followBill, unfollowBill, followUser and unfollowUser. Removed the files that implemented these functions.
AstorDG
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These fire base functions weren't being used anywhere in the code base. As part of the firebase v2 migration it made sense to remove them.
Steps to test/reproduce
The testing is just to make sure that the project still builds and there weren't any unintended consequences of deleting these functions and files.
You can just run the the environment locally with yarn dev:up and see that the project still builds. I also checked that you can still follow/unfollow bills and follow/unfollow users.