Skip to content

fix: add a missing await in tests/integration/common#2074

Merged
Mephistic merged 1 commit intocodeforboston:mainfrom
hyphacoop:fix/await-testdb
Mar 19, 2026
Merged

fix: add a missing await in tests/integration/common#2074
Mephistic merged 1 commit intocodeforboston:mainfrom
hyphacoop:fix/await-testdb

Conversation

@fastfadingviolets
Copy link
Contributor

Summary

Calls to testDb.create have to be awaited even if they go through a catch. This was a race condition that could be triggered on slower machines, etc.

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.
  • If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

Add some screenshots highlighting your changes.

Known issues

If you've run against limitations or caveats, include them here. Include follow-up issues as well.

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Go to the home page
  2. Click on a testimony
  3. See that it's loaded with a loading spinner

@vercel
Copy link

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment Mar 19, 2026 4:24pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
maple-prod Ignored Ignored Mar 19, 2026 4:24pm

Request Review

@fastfadingviolets fastfadingviolets changed the title Add a missing await in tests/integration/common fix: add a missing await in tests/integration/common Mar 19, 2026
Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Mephistic Mephistic merged commit 21ba422 into codeforboston:main Mar 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants