Skip to content

feat(create-cli): add categories codegen#1267

Merged
hanna-skryl merged 3 commits intomainfrom
categories-codegen
Mar 16, 2026
Merged

feat(create-cli): add categories codegen#1267
hanna-skryl merged 3 commits intomainfrom
categories-codegen

Conversation

@hanna-skryl
Copy link
Collaborator

Categories support has been added to the setup wizard's code generation. Plugins can now specify categories in their PluginCodegenResult, which are collected and displayed in the generated configuration. The categories block is skipped when no plugin provides categories, so the existing behavior remains unchanged.

This update is a prerequisite for plugin bindings that need to generate categories along with their plugin configuration.

@nx-cloud
Copy link

nx-cloud bot commented Mar 12, 2026

View your CI Pipeline Execution ↗ for commit 2e165ea

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 32s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 13m 39s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 30s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-16 14:55:17 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 110eb68 with previous commit d13cc6e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 35 🔴 34 ↓ −0.9
Updates 🟡 73 🟡 72 ↓ −0.4
Code coverage 🟢 92 🟢 92 ↑ +0.1
Documentation 🟡 52 🟡 52 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100
Security 🔴 0 🔴 0
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 2 groups improved, 👎 2 groups regressed, 👍 6 audits improved, 👎 4 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 35 🔴 34 ↓ −0.9
JS packages npm outdated dependencies 🟡 73 🟡 72 ↓ −0.4
Code coverage Code coverage metrics 🟢 92 🟢 92 ↑ +0.1
JSDocs coverage Documentation coverage 🟡 52 🟡 52 ↑ +0.1

30 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 740 ms 🟩 Root document took 560 ms ↓ −25 %
Lighthouse First Contentful Paint 🟥 3.4 s 🟥 3.1 s ↓ −7.2 %
Lighthouse Speed Index 🟥 6.4 s 🟥 6.7 s ↑ +4.9 %
Lighthouse Total Blocking Time 🟥 2,090 ms 🟥 2,940 ms ↑ +40.4 %
JS packages Outdated npm dev dependencies. 🟨 61 outdated package versions (30 major, 25 minor, 6 patch) 🟨 61 outdated package versions (32 major, 24 minor, 5 patch)  +0 %
Lighthouse Max Potential First Input Delay 🟥 660 ms 🟥 1,290 ms ↑ +95.7 %
JSDocs coverage Functions coverage 🟥 628 undocumented functions 🟥 632 undocumented functions ↑ +0.6 %
Code coverage Line coverage 🟩 92.6 % 🟩 92.6 % ↑ +0.1 %
Code coverage Branch coverage 🟨 89.1 % 🟨 89.2 % ↑ +0.1 %
Code coverage Function coverage 🟩 94.1 % 🟩 94.1 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,386 KiB 🟩 Total size was 2,421 KiB ↑ +1.5 %
Lighthouse Minimizes main-thread work 🟥 9.1 s 🟥 12.9 s ↑ +42.8 %
Lighthouse JavaScript execution time 🟥 2.9 s 🟥 4.3 s ↑ +47.8 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 322 KiB 🟥 Potential savings of 276 KiB ↓ −41.5 %
Lighthouse Server Backend Latencies 🟩 1,320 ms 🟩 720 ms ↓ −45.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 102 KiB 🟥 Potential savings of 109 KiB ↓ −31.3 %
Lighthouse Largest Contentful Paint 🟥 13.8 s 🟥 13.6 s ↓ −1.1 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 10 ms ↓ −84.6 %
Lighthouse Time to Interactive 🟥 14.6 s 🟥 14.6 s ↑ +0.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0.3 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 111 KiB 🟥 Potential savings of 111 KiB ↓ −8 %
JS packages Vulnerabilities for npm prod dependencies. 🟥 18 vulnerabilities (2 critical, 6 high, 3 moderate, 7 low) 🟥 19 vulnerabilities (2 critical, 7 high, 3 moderate, 7 low) ↑ +5.6 %
JS packages Vulnerabilities for npm dev dependencies. 🟥 72 vulnerabilities (3 critical, 40 high, 22 moderate, 7 low) 🟥 73 vulnerabilities (3 critical, 41 high, 22 moderate, 7 low) ↑ +1.4 %
Lighthouse Avoids an excessive DOM size 🟥 2,341 elements 🟥 2,340 elements ↓ −0.1 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

652 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 110eb68 with previous commit d13cc6e.

💼 Project create-cli

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 91 🟢 91 ↑ +0.2
Documentation 🔴 24 🔴 23 ↓ −0.1

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.2
JSDocs coverage Documentation coverage 🔴 24 🔴 23 ↓ −0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟥 48 undocumented functions 🟥 50 undocumented functions ↑ +4.2 %
Code coverage Function coverage 🟩 90.9 % 🟩 91.2 % ↑ +0.3 %
Code coverage Line coverage 🟩 94.1 % 🟩 94.3 % ↑ +0.3 %
Code coverage Branch coverage 🟩 91 % 🟩 91.1 % ↑ +0.1 %

439 other audits are unchanged.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 61 🟡 61 ↑ +0.1
Code coverage 🟢 94 🟢 94 ↑ +0.1

4 other categories are unchanged.

👍 2 groups improved, 👍 4 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 61 🟡 61 ↑ +0.1
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟥 253 undocumented functions 🟥 255 undocumented functions ↑ +0.8 %
Code coverage Branch coverage 🟩 91.4 % 🟩 91.4 % ↑ +0.1 %
Code coverage Function coverage 🟩 95.4 % 🟩 95.4 % ↑ +0.1 %
Code coverage Line coverage 🟩 97.6 % 🟩 97.6 % ↑ +0.1 %

440 other audits are unchanged.


12 other projects are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review March 12, 2026 18:52
@hanna-skryl hanna-skryl requested a review from matejchalk March 12, 2026 18:52
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1267

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1267

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1267

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1267

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1267

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1267

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1267

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1267

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1267

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1267

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1267

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1267

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1267

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1267

commit: 2e165ea

@hanna-skryl hanna-skryl requested a review from matejchalk March 13, 2026 20:19
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍

@hanna-skryl hanna-skryl merged commit b07d498 into main Mar 16, 2026
24 checks passed
@hanna-skryl hanna-skryl deleted the categories-codegen branch March 16, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants