You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
The pull request successfully updates turbo-rails to 2.0.23; however, it also introduces several major transitive dependency updates that are outside the scope of this change. Specifically, the bump to minitest 6.0.6 directly contradicts the turbo-rails v2.0.21 release notes, which recommend restricting minitest to versions below 6.0. Additionally, major updates to connection_pool (v3.0) and erb (v6.0) carry breaking change risks, such as new Ruby version requirements and dependencies on the Prism parser. These should be isolated into separate PRs to ensure stability.
About this PR
The update includes major version jumps for connection_pool (2.5 to 3.0) and erb (5.0 to 6.0). These updates are not strictly required for turbo-rails and introduce risks like the removal of ConnectionPool::Wrapper and new requirements for the Prism parser. It is recommended to revert these lockfile changes and run bundle update turbo-rails to isolate the specific dependency.
Test suggestions
Verify turbo-rails version update in Gemfile.lock
Run existing test suite to verify compatibility with minitest 6.0.6
Verify broadcast_refresh_to options forwarding behaves as expected
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Run existing test suite to verify compatibility with minitest 6.0.6
2. Verify broadcast_refresh_to options forwarding behaves as expected
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM RISK
This update bumps minitest to 6.0.6, which contradicts the turbo-rails v2.0.21 release notes explicitly recommending a restriction to 'minitest < 6'. This major version jump may cause instability in the test suite or incompatibility with turbo-rails' provided test helpers. Recommendation: Revert Gemfile.lock and run bundle update turbo-rails to isolate the update to the intended gem and its necessary dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesPull requests that update a dependency filerubyPull requests that update ruby code
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependabot
Bot
added
dependencies
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Bumps turbo-rails from 2.0.16 to 2.0.23.
Release notes
Sourced from turbo-rails's releases.
... (truncated)
Commits
435135bBump version22701f1@hotwired/turbo-railsv8.0.2327030b9Bump version52cde05@hotwired/turbo-railsv8.0.22e511fb2Bump version99dc9c5@hotwired/turbo-railsv8.0.20c2cd99fv8.0.2131c78afRespect broadcast suppressions on before/after actions (#770)16f7613Only return messages produced by block incapture_turbo_stream_broadcastsdda27a8Restrict tests tominitest<6Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)