[ROOT639] Updated root to tip of branch master#10475
Conversation
|
A new Pull Request was created by @akritkbehera for branch IB/CMSSW_17_0_X/rootmaster. @akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test |
|
-1 Failed Tests: UnitTests Failed Unit TestsI found 9 errors in the following unit tests: ---> test TestFWIORNTupleTempInputReducedProcessHistoryHardwareResources had ERRORS ---> test TestFWIORNTupleTempInputReducedProcessHistoryVersion had ERRORS ---> test TestFWIORNTupleTempInputRefProductIDMetadataConsistency had ERRORS and more ... Comparison SummarySummary:
|
|
All failing tests are about RNTuple, and they fail along |
|
I see |
|
The problem should get fixed with cms-sw/cmssw#50683 |
|
please test with cms-sw/cmssw#50683 |
|
Looking at the build log, the problem appears to be in So it looks like edmPluginRefresh crashed while trying to load The confusing bit about the log is edmPluginRefresh is running concurrently with the compiling of all the python code. |
|
It is also interesting that multiple threads are started just by loading a plugin. The only package I could find that uses |
|
please test with cms-sw/cmssw#50683 |
|
So I installed the PR locally and in |
|
However, If I process just that one plugin it works just fine. So the problem is because we have edmPluginRefresh running over the entire library. In fact, there is a |
|
If I explicitly exclude Excluding all 3 allows edmPluginRefresh to finish. |
|
Strangely enough, if I ONLY load any combination of the 3 plugins into edmPluginRefresh, it works fine. |
|
I think I may see the problem, although CondFormats/MLObjects uses ROOT, it was NOT checkout as part of the build done in this PR! |
|
If I explicitly add So the problem is the PR did not check out all the needed packages when doing the build. |
|
test parameters:
|
|
@cmsbuild, please test |
Good catch. I opened cms-sw/cmssw#50692 to add the dependence there. |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed Unit TestsI found 2 errors in the following unit tests: ---> test TestFWCoreReflectionClassVersionUpdate had ERRORS ---> test TestIOPoolInputNoParentDictionary had ERRORS Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 33 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
ignore tests-rejected with manual-override These two unit tests fail every time update ROOT, so this update seems to be good to go in now. |
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/rootmaster IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
bb8eb5c
into
cms-sw:IB/CMSSW_17_0_X/rootmaster
No description provided.