Evict file cache when cf-pcap flag changes#1118
Merged
ameowlia merged 1 commit intocloudfoundry:developfrom Mar 26, 2026
Merged
Evict file cache when cf-pcap flag changes#1118ameowlia merged 1 commit intocloudfoundry:developfrom
ameowlia merged 1 commit intocloudfoundry:developfrom
Conversation
Since the flag controls whether rep can extract extended file attributes or not, the cache needs to be invalidated when the flag changes. Otherwise the extended file attributes might be missing after enabling the feature or they might still linger around even though the operator already disabled the feature.
Member
Author
|
Even though the issue was resolved I'm still convinced that this change fixes a bug and we should merge it in. |
ameowlia
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the flag controls whether rep can extract extended file attributes or not, the cache needs to be invalidated when the flag changes. Otherwise the extended file attributes might be missing after enabling the feature or they might still linger around even though the operator already disabled the feature.
Backward Compatibility
Breaking Change? No
Resolves #1117