Reduce db calls when presenting processes#4889
Draft
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Draft
Reduce db calls when presenting processes#4889philippthun wants to merge 1 commit intocloudfoundry:mainfrom
philippthun wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
5 tasks
philippthun
force-pushed
the
process-presenter-eager-loading
branch
from
15d150a to
559b248
Compare
Eager load apps, buildpack_lifecycle_data, and cnb_lifecycle_data. This data is needed to determine if the process belongs to a docker app to then either get the run_action_user from the execution_metadata or return a default user name. Also remove the check if a droplet belongs to a docker app in 'docker_user'. This issues one or two db requests (check if buildpack_lifecycle_data or cnb_lifecycle_data exists) and it is only called from process_model and task_model (docker_run_action_user) after it has already been verified that it's a docker app.
philippthun
force-pushed
the
process-presenter-eager-loading
branch
from
559b248 to
69887f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eager load
apps,buildpack_lifecycle_data, andcnb_lifecycle_data. This data is needed to determine if the process belongs to a docker app to then either get therun_action_userfrom theexecution_metadataor return a default user name.Also remove the check if a droplet belongs to a docker app in
docker_user. This issues one or two db requests (check ifbuildpack_lifecycle_dataorcnb_lifecycle_dataexists) and it is only called fromprocess_modelandtask_model(docker_run_action_user) after it has already been verified that it's a docker app.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests