[build] Enable ISA extensions globally in release builds#6243
Open
[build] Enable ISA extensions globally in release builds#6243
Conversation
Contributor
|
ResolveMessage: Cannot find module '@opencode-ai/plugin' from '/home/runner/work/workerd/workerd/.opencode/tools/bazel-deps.ts' |
Contributor
|
@fhanau Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
|
The generated output of |
As a long-term solution for which hardware flags to enable, we enable the flags we need on all of workerd in release builds. Alongside capnproto/capnproto#2582, this should fix the footgun responsible for #5977 for good as the CRC-based hash is only used when all of workerd is built with the given CPU flags.
fhanau
force-pushed
the
felix/030326-bazel-crc
branch
from
84d5fd0 to
29ef6d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a long-term solution for which hardware flags to enable, we enable the flags we need on all of workerd in release builds. Alongside capnproto/capnproto#2582, this should fix the footgun responsible for #5977 for good as the CRC-based hash is only used when all of workerd is built with the given CPU flags.
Also see #2582.