fix: correct isinstance check to include bytearray in kafka conversion#267
Merged
xSAVIKx merged 1 commit intocloudevents:v2from Mar 7, 2026
Merged
Conversation
The isinstance check in to_structured had a duplicate `bytes` entry instead of `bytearray`, meaning bytearray data would not be correctly base64-encoded in the structured kafka message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Artem Muterko <artem@sopho.tech>
archy-rock3t-cloud
force-pushed
the
fix/kafka-bytearray-isinstance
branch
from
89fabd9 to
c6cb965
Compare
xSAVIKx
approved these changes
Mar 7, 2026
Member
|
Thank you for the fix @archy-rock3t-cloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
isinstance(data, (bytes, bytes, memoryview))inv1/kafka/conversion.pyhasbyteslisted twice — the second should bebytearray, matchingcore/bindings/kafka.pyandv1/event/base.py.One line description for the changelog
Fix isinstance check to include bytearray in kafka structured conversion