Skip to content

chore: add default values for id, time and specversion#264

Open
PlugaruT wants to merge 2 commits intocloudevents:v2from
PlugaruT:tudor/add-defaults-to-attrs
Open

chore: add default values for id, time and specversion#264
PlugaruT wants to merge 2 commits intocloudevents:v2from
PlugaruT:tudor/add-defaults-to-attrs

Conversation

@PlugaruT
Copy link

Fixes #

Changes

One line description for the changelog

  • Tests pass
  • Appropriate changes to README are included in PR

Signed-off-by: PlugaruT <plugaru.tudor@protonmail.com>
@PlugaruT
Copy link
Author

@xSAVIKx here is the PR about having default values for some of the fields just as on v1

Signed-off-by: PlugaruT <plugaru.tudor@protonmail.com>
Copy link
Member

@xSAVIKx xSAVIKx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PlugaruT overall looks good. Can you please add some docs to the constructors and mention how and what is set automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants