fix(clerk-js): Prevent session cookie removal during offline token refresh by bratsos · Pull Request #7912 · clerk/javascript

bratsos · 2026-02-23T19:58:12Z

Description

When offline, two code paths in Session.ts emit token:update events with empty tokens. AuthCookieService interprets empty tokens as signed-out and removes the __session cookie — even though the session is still valid server-side. On the next page load or visibility change, the missing cookie makes the user appear signed out.

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

Bug Fixes
- Fixed unexpected sign-outs that occurred when the browser temporarily lost network connectivity.

changeset-bot · 2026-02-23T19:58:16Z

🦋 Changeset detected

Latest commit: 2377201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-02-23T19:58:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	Feb 25, 2026 6:04pm

pkg-pr-new · 2026-02-23T20:01:36Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7912

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7912

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7912

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7912

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7912

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7912

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7912

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7912

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7912

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7912

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@7912

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7912

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7912

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7912

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7912

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7912

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7912

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7912

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7912

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7912

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7912

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7912

commit: 2377201

jacekradko · 2026-02-23T20:31:12Z

packages/clerk-js/src/core/resources/__tests__/Session.test.ts


    describe('with offline browser and network failure', () => {
      beforeEach(() => {
-        // Use real timers for offline tests to avoid unhandled rejection issues with retry logic


coderabbitai · 2026-02-25T12:20:10Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 992a3ba and 2377201.

📒 Files selected for processing (3)

.changeset/three-ads-fold.md
packages/clerk-js/src/core/resources/Session.ts
packages/clerk-js/src/core/resources/__tests__/Session.test.ts

📝 Walkthrough

Walkthrough

This pull request adds a patch release for @clerk/clerk-js that addresses random sign-outs during temporary network loss. Changes include: refactoring the _getToken method in Session.ts to prevent emitting empty token updates while offline, adding explicit error handling to trigger retry logic, and skipping cache/dispatch operations for empty tokens during offline states. Corresponding test updates expand coverage for offline token scenarios, including background refresh behavior and event emission patterns.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main fix: preventing session cookie removal during offline token refresh. It's specific, clear, and directly relates to the core problem solved in the changeset (gating TokenUpdate emissions when offline).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…fresh

brkalow · 2026-02-27T03:00:42Z

packages/clerk-js/src/core/resources/Session.ts

+    // Throw when offline and no token so retry() in getToken() can fire.
+    // Without this, _getToken returns null (success) and retry() never calls shouldRetry.
+    if (result === null && !isValidBrowserOnline()) {
+      throw new ClerkRuntimeError('Network request failed while offline', { code: 'network_error' });


Recommend that we re-use ClerkOfflineError here

brkalow · 2026-02-27T03:02:22Z

packages/clerk-js/src/core/resources/Session.ts

-      return cachedToken.getRawString() || null;
+      result = cachedToken.getRawString() || null;
+    } else {
+      result = await this.#fetchToken(template, organizationId, tokenId, shouldDispatchTokenUpdate, skipCache);


does this throw if offline? should we avoid fetching if we're offline in the first place?

github-actions bot added clerk-js core-3 labels Feb 23, 2026

jacekradko reviewed Feb 23, 2026

View reviewed changes

bratsos force-pushed the alexbratsos/user-4744-investigate-random-sign-outs-in-the-dashboard-possibly branch from d134aeb to c230146 Compare February 25, 2026 12:05

vercel bot deployed to Preview February 25, 2026 12:06 View deployment

vercel bot deployed to Preview February 25, 2026 17:14 View deployment

fix(clerk-js): Prevent session cookie removal during offline token re…

2377201

…fresh

bratsos force-pushed the alexbratsos/user-4744-investigate-random-sign-outs-in-the-dashboard-possibly branch from 992a3ba to 2377201 Compare February 25, 2026 18:04

vercel bot deployed to Preview February 25, 2026 18:04 View deployment

brkalow reviewed Feb 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(clerk-js): Prevent session cookie removal during offline token refresh#7912

fix(clerk-js): Prevent session cookie removal during offline token refresh#7912
bratsos wants to merge 1 commit intomainfrom
alexbratsos/user-4744-investigate-random-sign-outs-in-the-dashboard-possibly

bratsos commented Feb 23, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

vercel bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

jacekradko Feb 23, 2026

Uh oh!

coderabbitai bot commented Feb 25, 2026 •

edited

Loading

Walkthrough

Uh oh!

brkalow Feb 27, 2026

Uh oh!

brkalow Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bratsos commented Feb 23, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacekradko Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

brkalow Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

brkalow Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bratsos commented Feb 23, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Feb 23, 2026 •

edited

Loading

vercel bot commented Feb 23, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 23, 2026 •

edited

Loading

coderabbitai bot commented Feb 25, 2026 •

edited

Loading