Use more intuitive sun controls; refactor code#1577
Open
Peregrine05 wants to merge 4 commits intochunky-dev:masterfrom
Open
Use more intuitive sun controls; refactor code#1577Peregrine05 wants to merge 4 commits intochunky-dev:masterfrom
Peregrine05 wants to merge 4 commits intochunky-dev:masterfrom
Conversation
…ode out to another method.
- Re-added an `Enable sunlight` control, which replaces `Sun Sampling Strategy`: `NON_LUMINOUS`. - Added a control to enable and disable skymap interpolation. - Refactored code that returns sky color.
Member
|
Should unchecking |
leMaik
reviewed
Apr 21, 2023
leMaik
reviewed
Apr 21, 2023
Comment on lines
-452
to
-454
| ray.color.scale(skyExposure); | ||
| ray.color.scale(apparentSkyLightModifier); | ||
| addSunColor(ray); |
Member
There was a problem hiding this comment.
This method is public. Is it intended to not apply exposure, sky light modifier and sun here anymore?
Member
Author
There was a problem hiding this comment.
It is only accessed from within Sky.java, so it can be made private (the same goes with getSkyDiffuseColorInner). It is no longer intended to apply modifications to the sky color in the getSkyColorInterpolated method; modifications are now done in the getSkyColor method, after getting the base sky color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable sunlightcontrol, which replacesSun Sampling Strategy:NON_LUMINOUS.