fix: --reporter flag to support multiple values#1243
Merged
timohuovinen merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
b9254be to
2d3638e
Compare
2d3638e to
c374059
Compare
sorccu
requested changes
Mar 6, 2026
Contributor
Author
|
@sorccu added as much detail as I can, good now? |
sorccu
approved these changes
Mar 6, 2026
Member
|
Alright. If you also want to release, look at contributing.md. |
c374059 to
612aeaf
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components
Notes for the Reviewer
This allows the reporter flag to support multiple params
normally in the form
This is also consistent with our existing
-eand-iflag usage.I've decided to use the existing flag parsing library function
multiple: trueto keep things consistent, instead of the suggestednpx checkly test --reporter list,json, which would have affected a lot more code and made flag usage within the CLI inconsistentReasoning for multiple reporters:
The
--reporter(-r) flag previously only accepted a single value. Users who wanted both human-readable terminal output and machine-parseable output in the same run had no way to achieve this, they'd have to choose one or the otherThe code was already built to support multiple reporters, and looks like the flag was always intended to support multiple reporters, but not fully implemented, so generally this is mostly a fix for a missing but expected feature.
i.e. the createReporters already returned an array of Reporter instances and the runner iterated all of them, the limitation was purely in how the CLI flag was parsed and passed through.
Note that playwright's
--reporterflag, which also supports multiple reporters, uses a CSV approach, as in--reporter list,json. https://playwright.dev/docs/test-reporters