Skip to content

cfengine lint: Moved ifvarclass and bundle name lowercase into strict mode #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olehermanse merged 1 commit into from
May 6, 2026
Merged

cfengine lint: Moved ifvarclass and bundle name lowercase into strict mode #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/cfengine_cli/lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,11 @@ def _lint_block_name(node: Node, state: State, location: str, syntax_data: Synta
"""Check that a block name follows conventions and doesn't shadow a built-in."""
assert node.type in ("bundle_block_name", "body_block_name", "promise_block_name")

if node.type == "bundle_block_name" and _text(node) != _text(node).lower():
if (
state.strict
and node.type == "bundle_block_name"
and _text(node) != _text(node).lower()
):
raise ValidationError(
f"Convention: Bundle name should be lowercase {location}", node
)
Expand Down Expand Up @@ -763,7 +767,7 @@ def _lint_attribute_name(
"""Check an attribute name for deprecations and validity according to the
surrounding promise type."""
assert node.type == "attribute_name"
if _text(node) == "ifvarclass":
if state.strict and _text(node) == "ifvarclass":
raise ValidationError(
f"Deprecation: Use 'if' instead of 'ifvarclass' {location}", node
)
Expand Down
Loading