Implemented spawn config validation

[victormlg]

No description provided.

[victormlg]

It looks like typing.Annotated was added in python 3.9 https://docs.python.org/3/library/typing.html#typing.Annotated, thus the error

[olehermanse]

Please move this functionality and PR to CFEngine CLI. It already has cf-remote as a dependency so you can import the things you need from cf-remote.

Rationale:

• cf-remote (and cfbs) need to run on many older platforms we support, and thus need to work on older pythons.
• In general, this also makes it harder for us to use (pip) dependencies in cf-remote and cfbs.
• CFEngine CLI explicitly only targets newer OSes and Pythons. It is not meant to run on all clients or all hubs - it only needs to work on people's laptops or workstations.

Longer term we can look at moving all of cf-remote spawn to CFEngine CLI, I think.

[olehermanse]

Here you are adding 2 dependencies, to be installed in GH Actions only. These changes would cause ImportErrors for anyone who installs and runs the new version of cf-remote.

To add a dependency, you need to update setup.py and requirements.txt.

With that said, and also considering the fact that your code does not work on older Pythons, it might be better if we move this new functionality to CFEngine CLI.

[olehermanse]

It looks like typing.Annotated was added in python 3.9 https://docs.python.org/3/library/typing.html#typing.Annotated, thus the error

FYI, we cannot ignore these errors - if you were going to get this merged here you'd need to fix it. Luckily it will go away if we move it to CFEngine CLI.