Skip to content

Change to use import maps for @cardstack/catalog#4186

Merged
backspace merged 10 commits intomainfrom
cs-10440-change-to-use-import-maps-for-cardstackcatalog-references
Mar 23, 2026
Merged

Change to use import maps for @cardstack/catalog#4186
backspace merged 10 commits intomainfrom
cs-10440-change-to-use-import-maps-for-cardstackcatalog-references

Conversation

@backspace
Copy link
Copy Markdown
Contributor

@backspace backspace commented Mar 13, 2026

This updates how @cardstack/catalog references are handled, delaying resolution into URLs as late as possible so cards can use them in relationships and cards and card definitions can use them for module imports. addImportMap in the virtual network already existed but was one-way, resulting in environment-specific catalog realm URLs being scattered through cards and the database. Now an environment-specific realm URL can be “unresolved” back into @cardstack/catalog.

Forthcoming work:

  • adding @cardstack/skills similarly
  • lint rule to convert environment-specific references to universal ones (https://app.boxel.ai/catalog to @cardstack/catalog)
  • migrating to @cardstack/base, the big one

@backspace backspace self-assigned this Mar 13, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2026

Host Test Results

    1 files  ± 0      1 suites  ±0   2h 9m 30s ⏱️ + 10m 53s
2 030 tests +80  2 015 ✅ +81  15 💤 ±0  0 ❌ ±0 
2 045 runs  +81  2 030 ✅ +83  15 💤 ±0  0 ❌  - 1 

Results for commit a275491. ± Comparison against base commit fffbaff.

This pull request removes 1 and adds 81 tests. Note that renamed tests count towards both.
Chrome ‑ error
Chrome ‑ Integration | ai-assistant-panel | skills: adding skill card results in new command definitions being added but not duplicated
Chrome ‑ Integration | ai-assistant-panel | skills: updated command definition results in new event and updated room state
Chrome ‑ Integration | ai-assistant-panel | skills: updated skill card instructions result in new event and updated room state when code patch is completing
Chrome ‑ Integration | ai-assistant-panel | skills: updated skill card instructions result in new event and updated room state when command is completing
Chrome ‑ Integration | operator-mode | links: Clicking on "Finish Editing" after creating a card from linksTo field will switch the card into isolated mode
Chrome ‑ Integration | operator-mode | links: New cards are optimistically created for a linksTo field
Chrome ‑ Integration | operator-mode | links: already-linked cards are excluded from the multi-select chooser
Chrome ‑ Integration | operator-mode | links: can add a card to a linksTo field creating a loop
Chrome ‑ Integration | operator-mode | links: can add a card to a linksToMany field with existing values
Chrome ‑ Integration | operator-mode | links: can add a card to linksToMany field that has a null value for relationship
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

Preview deployments

@backspace backspace marked this pull request as ready for review March 18, 2026 14:49
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44df01a6f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/runtime-common/definition-lookup.ts Outdated
Comment thread packages/runtime-common/catalog.ts Outdated
Comment thread packages/runtime-common/index-runner/card-indexer.ts
@backspace backspace requested a review from a team March 19, 2026 14:36
…e-import-maps-for-cardstackcatalog-references

# Conflicts:
#	packages/runtime-common/loader.ts
@backspace backspace merged commit 55a0f23 into main Mar 23, 2026
115 of 116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants