Change to use import maps for @cardstack/catalog#4186
Merged
Conversation
Host Test Results 1 files ± 0 1 suites ±0 2h 9m 30s ⏱️ + 10m 53s Results for commit a275491. ± Comparison against base commit fffbaff. This pull request removes 1 and adds 81 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Preview deployments |
…e-import-maps-for-cardstackcatalog-references
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44df01a6f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tackcatalog-references
…tackcatalog-references
burieberry
approved these changes
Mar 23, 2026
…e-import-maps-for-cardstackcatalog-references # Conflicts: # packages/runtime-common/loader.ts
jurgenwerk
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates how
@cardstack/catalogreferences are handled, delaying resolution into URLs as late as possible so cards can use them in relationships and cards and card definitions can use them for module imports.addImportMapin the virtual network already existed but was one-way, resulting in environment-specific catalog realm URLs being scattered through cards and the database. Now an environment-specific realm URL can be “unresolved” back into@cardstack/catalog.Forthcoming work:
@cardstack/skillssimilarlyhttps://app.boxel.ai/catalogto@cardstack/catalog)@cardstack/base, the big one