[DPE-10163] Compatibility class for PGB#128
Merged
Merged
Conversation
dragomirp
changed the title
dragomirp
changed the title
dragomirp
commented
May 20, 2026
| """Exception raised when enabling/disabling an extension fails.""" | ||
|
|
||
|
|
||
| class PostgreSQLBase: |
Contributor
Author
There was a problem hiding this comment.
Base class for PGB, so that we maintain a minimum of 3.8 compatible code.
dragomirp
commented
May 20, 2026
Contributor
Author
There was a problem hiding this comment.
literals are used around the place. We can update the substrate to StrEnum in 3.12, but that's not available for 3.8.
dragomirp
commented
May 20, 2026
| from ..compat.postgresql import ( | ||
| ACCESS_GROUP_RELATION, | ||
| ALLOWED_ROLES, | ||
| INVALID_DATABASE_NAME_BLOCKING_MESSAGE, # noqa: F401 |
Contributor
Author
There was a problem hiding this comment.
Imported to keep the namespace consistent. Alternatively, we can define exports instead of noqa.
dragomirp
commented
May 20, 2026
|
|
||
|
|
||
| class PostgreSQL: | ||
| class PostgreSQL(PostgreSQLBase): |
Contributor
Author
There was a problem hiding this comment.
Moved duplicate functions to the base class.
dragomirp
requested review from
carlcsaposs-canonical,
juju-charm-bot,
marceloneppel and
taurus-forever
and removed request for
a team
taurus-forever
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compatibility module to limit the amount of 3.8 code necessary.
Testing on: