Skip to content

fix(applive): post-prod hotfixes — bug 001 quit→restart hang #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayank2498 merged 2 commits into from
May 25, 2026
Merged

fix(applive): post-prod hotfixes — bug 001 quit→restart hang #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
764bd71
fix(applive): quit button must detach, not delete session
mayank2498 May 25, 2026
2d96fe7
fix(session-builder): tolerate non-array res.value from sessions endp…
mayank2498 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/common/renderer/actions/SessionBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,13 @@ async function fetchAllSessions(baseUrl, headers) {
async function fetchSessionsFromEndpoint(url) {
try {
const res = await fetchSessionInformation({url, headers});
return url === seleniumSessionsEndpoint ? formatSeleniumGridSessions(res) : (res.value ?? []);
const value = url === seleniumSessionsEndpoint
? formatSeleniumGridSessions(res)
: (res.value ?? []);
// Some Appium servers return `{value: {error: "unknown command", ...}}` from these
// endpoints — a non-iterable object — which used to throw on the spread below and
// silently empty the session list. Treat any non-array as "no sessions".
return Array.isArray(value) ? value : [];
} catch {
return [];
}
Expand Down
8 changes: 7 additions & 1 deletion app/common/renderer/components/SessionInspector/Header/HeaderButtons.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,13 @@ const HeaderButtons = (props) => {
</Tooltip>
)}
<Tooltip title={t('Quit Session')}>
<Button id="btnClose" icon={<IconX size={18} />} onClick={quitSessionAndReturn} />
<Button
id="btnClose"
icon={<IconX size={18} />}
onClick={() =>
quitSessionAndReturn(window.AppLiveSessionId ? {detachOnly: true} : undefined)
}
/>
</Tooltip>
</Space.Compact>
);
Expand Down