fix(security): use atomic temp-dir swap for cache updates [DEVA11Y-482]#21
Open
sunny-se wants to merge 1 commit into
Open
fix(security): use atomic temp-dir swap for cache updates [DEVA11Y-482]#21sunny-se wants to merge 1 commit into
sunny-se wants to merge 1 commit into
Conversation
F-013 / DEVA11Y-482 — prepareArtifact had a TOCTOU race (CWE-362) where the check-delete-create-download sequence left a large window for parallel builds to corrupt state. Download into a temp directory and atomically move to the version directory after completion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepareArtifact()had a TOCTOU race (CWE-362): the check-delete-create-download sequence left a large window where parallel builds could corrupt each other's cache state.defercleans up the temp directory automatically.Verification
swift build)forceDownloadflag triggers fresh download into temp dir and atomic swapReferences
🤖 Generated with Claude Code