Skip to content

fix(security): sanitize version string to prevent path traversal [DEVA11Y-480] #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunny-se wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix(security): sanitize version string to prevent path traversal [DEVA11Y-480] #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Plugins/BrowserStackAccessibilityLint/BrowserStackAccessibilityLint.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,8 +557,13 @@ private func hardwareIdentifier() throws -> String {
private func extractVersion(from url: URL) -> String? {
let filename = url.deletingPathExtension().lastPathComponent
if let range = filename.range(of: "-", options: .backwards) {
let version = filename[range.upperBound...]
return version.isEmpty ? nil : String(version)
let version = String(filename[range.upperBound...])
if version.isEmpty { return nil }
// Reject path traversal and non-semver characters
let allowed = CharacterSet.alphanumerics.union(CharacterSet(charactersIn: ".-+"))
guard version.unicodeScalars.allSatisfy({ allowed.contains($0) }) else { return nil }
guard !version.contains("..") else { return nil }
return version
}
return nil
}
Expand Down
Loading