Skip to content

fix(security): restrict download URL override to HTTPS only [DEVA11Y-479] #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunny-se wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

fix(security): restrict download URL override to HTTPS only [DEVA11Y-479] #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Plugins/BrowserStackAccessibilityLint/BrowserStackAccessibilityLint.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,13 @@ private func parseOverride(urlString: String?) throws -> URL? {
guard let urlString = urlString, !urlString.isEmpty else {
return nil
}
if let url = URL(string: urlString), let scheme = url.scheme, ["http", "https", "file"].contains(scheme.lowercased()) {
return url
guard let url = URL(string: urlString), let scheme = url.scheme else {
throw PluginError("Invalid download URL: \(urlString). Only HTTPS URLs are supported.")
}
guard scheme.lowercased() == "https" else {
throw PluginError("Unsupported URL scheme '\(scheme)' in download URL. Only HTTPS is allowed.")
}
return URL(fileURLWithPath: urlString)
return url
}

private func sanitizeArguments(_ arguments: [String]) -> [String] {
Expand Down
Loading