fix(security): remove insecure self-update from cli.sh scripts [DEVA11Y-475]#16
Open
sunny-se wants to merge 1 commit into
Open
fix(security): remove insecure self-update from cli.sh scripts [DEVA11Y-475]#16sunny-se wants to merge 1 commit into
sunny-se wants to merge 1 commit into
Conversation
F-003 / DEVA11Y-475 — script_self_update() fetched the script from a mutable branch head with no integrity verification (CWE-494). The ^#! regex check is trivially bypassed. Remove self-update entirely; users should update via git pull or package manager. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script_self_update()function and its invocation from all 3 CLI scriptsWhy:
script_self_update()fetched the script from a mutable branch head (refs/heads/main) via curl with no integrity verification (CWE-494). The only guard was a^#!regex — trivially bypassed by any attacker who controls the response. This ran unconditionally before any subcommand, making it a silent supply-chain vector.Users should update scripts via
git pullor their package manager.Verification
Jira
DEVA11Y-475 — F-003
🤖 Generated with Claude Code