brainprep/interfaces/freesurfer: sort group level csv by subject id#46
Merged
AGrigis merged 2 commits intobrainprepdesk:devfrom Apr 1, 2026
Merged
brainprep/interfaces/freesurfer: sort group level csv by subject id#46AGrigis merged 2 commits intobrainprepdesk:devfrom
AGrigis merged 2 commits intobrainprepdesk:devfrom
Conversation
AGrigis
requested changes
Mar 23, 2026
| df = pd.read_csv(file) | ||
| first_col = df.columns[0] | ||
| df = df.sort_values(by=first_col) | ||
| df.to_csv(file, index=False) |
Contributor
There was a problem hiding this comment.
This section of the code break the CI.
You can for instance create a pywrapper utility interface that will reorder any table with pandas.
Contributor
Author
There was a problem hiding this comment.
I checked the option you proposed, but I don't think it is possible to do this way. The issue is that the freesurfer command saves directly the csv, so we need to load them back anyway to have access to them in the brainprep script.
The easiest solution to implement is just to parse the output_dir looking for csv/tsv instead of looping over the summary_files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.