feat: store authentication token in secret storage#632
Merged
congminh1254 merged 9 commits intoadd_pkce_supportfrom Mar 9, 2026
Merged
feat: store authentication token in secret storage#632congminh1254 merged 9 commits intoadd_pkce_supportfrom
congminh1254 merged 9 commits intoadd_pkce_supportfrom
Conversation
Pull Request Test Coverage Report for Build 22837876813Details
💛 - Coveralls |
congminh1254
changed the title
keychain and keytar dependencies
congminh1254
changed the title
keychain and keytar dependencies
Pask423
requested changes
Mar 9, 2026
| try { | ||
| keytar = require('keytar'); | ||
| } catch { | ||
| // keytar cannot be imported because the library is not provided for this operating system / architecture |
Collaborator
There was a problem hiding this comment.
should/can we add some log here to the use
Member
Author
There was a problem hiding this comment.
We are doing some logging when we try to use this lib, but the lib is undefined. But if we do it here, user will see the message everytime they run any command.
| }) | ||
| ); | ||
|
|
||
| Promise.all(promises) |
Collaborator
There was a problem hiding this comment.
does this promisses affects one another ?
arjankowski
reviewed
Mar 9, 2026
| | **Windows** | Credential Manager | Built-in | | ||
| | **Linux** | Secret Service (libsecret) | May require installation | | ||
|
|
||
| ### Linux Installation |
KwiatkowskiML
approved these changes
Mar 9, 2026
arjankowski
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.