[PM-31920] Remove Unused Sprocs

[sven-bitwarden]

🎟️ Tracking

PM-31920

📔 Objective

A prior PR (#6890) made copies of these soon-to-be-deleted sprocs with a more accurate name. Now that nothing is referencing them and we've waited a release, they're good to be dropped.

📷 Screenshots

[github-actions]

Checkmarx One – Scan Summary & Details – b33a8fd6-4e53-4383-a8ba-1f1c53edac64

Great job! No new security vulnerabilities introduced in this pull request

[claude]

Claude finished @sven-bitwarden's task in 1m 36s —— View job

---

Code Review: PR #7060 - Remove Unused Sprocs

• Gather context and review PR changes
• Check for remaining references to deleted sprocs
• Review migration script
• Post review findings

---

Summary

This PR removes three stored procedures that were replaced with more accurately named versions in PR #6890. The changes are clean and straightforward.

Findings

No issues found. This is a well-structured cleanup PR.

Verification details:

• Replacement sprocs confirmed: All three deleted sprocs have active replacements created in PR [PM-25106] Refactor Misleading Stored Procedure/Repository Language #6890:

  • CollectionUser_ReadByOrganizationUserIds → CollectionUser_ReadSharedCollectionsByOrganizationUserIds
  • OrganizationUserUserDetails_ReadWithCollectionsById → OrganizationUserUserDetails_ReadWithSharedCollectionsById
  • Collection_ReadByOrganizationIdWithPermissions → Collection_ReadSharedCollectionsByOrganizationIdWithPermissions

• No remaining code references: All references to the deleted sproc names exist only in historical migration scripts (as expected). No C# code or other SQL definitions reference these names.

• Migration script is correct: The 2026-02-23_00_RemoveUnusedCollectionSprocs.sql file properly uses IF OBJECT_ID(...) IS NOT NULL guards before each DROP PROCEDURE, which is the expected idempotent pattern for safe migrations.

• File deletions match migration: The three .sql definition files removed from src/Sql/dbo/ correspond exactly to the three procedures dropped in the migration script.

• CI status: Build, testing, and database testing are in progress. SonarQube and Checkmarx scans have passed with no issues.

No concerns with this PR. It follows the standard pattern for dropping deprecated stored procedures after a release cycle.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@98d6217). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7060   +/-   ##
=======================================
  Coverage        ?   60.68%           
=======================================
  Files           ?     2013           
  Lines           ?    88122           
  Branches        ?     7846           
=======================================
  Hits            ?    53480           
  Misses          ?    32742           
  Partials        ?     1900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.