[DRAFT] Test change set version compatibility#396
Draft
ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
Draft
[DRAFT] Test change set version compatibility#396ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
This tells serde to use the default value if the field is missing when deserializing, which is useful when upgrading between versions.
Added `bdk_wallet` 2.3.0 to dev-dependencies. Added file `tests/changeset.rs`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
- Coverage 79.17% 79.06% -0.11%
==========================================
Files 24 24
Lines 5311 5298 -13
Branches 242 241 -1
==========================================
- Hits 4205 4189 -16
- Misses 1029 1032 +3
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trying out a new approach to testing change set version compatibility on a continuous basis.
Currently builds on #391
cc #234
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
just pbefore pushingNew Features:
Bugfixes: