Fix embedded mnemonic share index capacity#59
Open
digzrow-coder wants to merge 2 commits into
Open
Conversation
Refactor embedded index handling to include checksum bit length calculation and maximum shares validation.
Add test for splitMnemonic with embedded indexes and checksum capacity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55.
This validates how many embedded share indexes can fit in a mnemonic checksum before generating shares, and uses the minimum bit width needed for share indexes
1..total.For 12-word mnemonics this allows the valid boundary of 15 embedded shares and rejects 16 with a clear error instead of producing unrecoverable shares.
Verified locally: