500 modal with available keyboard shortcuts#1416
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an in-app “Keyboard shortcuts” modal to the image and video annotators (accessible from the settings tab) and de-duplicates the shortcuts documentation by extracting it into shared Blade partials used by both the manual and the modal.
Changes:
- Introduce a reusable
shortcutsButtonVue component that opens a modal and renders provided shortcuts content via slot. - Extract image/video shortcuts tables into
resources/views/partials/*-annotation-shortcuts.blade.phpand reuse them in the manual pages. - Add styling to keep settings top actions sticky and make the shortcuts modal scrollable.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/views/videos/show/sidebar-settings.blade.php | Adds shortcuts button (modal trigger) to video settings tab and tweaks screenshot button label/layout. |
| resources/views/partials/video-annotation-shortcuts.blade.php | New shared partial containing the video shortcuts content (used in manual + modal). |
| resources/views/partials/image-annotation-shortcuts.blade.php | New shared partial containing the image shortcuts content (used in manual + modal). |
| resources/views/manual/tutorials/videos/shortcuts.blade.php | Replaces duplicated manual content with an include of the new video shortcuts partial. |
| resources/views/manual/tutorials/annotations/shortcuts.blade.php | Replaces duplicated manual content with an include of the new image shortcuts partial. |
| resources/views/annotations/show/tabs/settings.blade.php | Adds shortcuts button (modal trigger) to image annotator settings tab and tweaks screenshot button label/layout. |
| resources/assets/sass/videos/main.scss | Imports shared settings tab styles for the video annotator UI. |
| resources/assets/sass/components/_settingsTab.scss | New styles for sticky top actions area and shortcuts modal scrolling. |
| resources/assets/sass/annotations/sidebar/_main.scss | Imports shared settings tab styles for the image annotator sidebar. |
| resources/assets/js/videos/components/settingsTab.vue | Registers the new shortcutsButton component for the video settings tab template. |
| resources/assets/js/core/components/shortcutsButton.vue | New modal-trigger component that teleports modal markup to <body> and renders slot content. |
| resources/assets/js/annotations/components/settingsTab.vue | Registers the new shortcutsButton component for the image settings tab template. |
| resources/assets/js/annotations/components/screenshotButton.vue | Renames button label to “Screenshot”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…com:biigle/core into 500-modal-with-available-keyboard-shortcuts
Member
|
Is this ready for review again? |
mzur
requested changes
Apr 9, 2026
mzur
reviewed
Apr 15, 2026
Member
mzur
left a comment
mzur
left a comment
There was a problem hiding this comment.
Looks good. Only one unnecessary import in the CSS which I'll remove myself.
mzur
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #500