Closed
Conversation
Contributor
|
Hi !
Current ABC is not using windows-2019 now and CI runs successfully. |
Author
|
@wjrforcyber oh yeah.. I think i got a bit confused! >< closing. |
Contributor
|
What about the other Windows fixes in #435? Have they already been applied? |
Contributor
No, I don't think so. Maybe re-emphasis it again in your original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI is failing because GitHub has deprecated the windows-2019 runner image.
This PR fixes to run on windows-latest, along with some small fixes needed for latest Win32 from PR #435 (thanks @cr1901!).