Add MinGW/MSYS2 build support and CI#491
Closed
robtaylor wants to merge 2 commits intoberkeley-abc:masterfrom
Closed
Add MinGW/MSYS2 build support and CI#491robtaylor wants to merge 2 commits intoberkeley-abc:masterfrom
robtaylor wants to merge 2 commits intoberkeley-abc:masterfrom
Conversation
Add a new build-mingw.yml workflow that builds ABC using MinGW64/MSYS2 on windows-latest. This provides CI coverage for the MinGW build path added in the previous commit, using ABC_USE_STDINT_H=1 and -DWIN32 -DWIN32_NO_DLL to handle MinGW platform quirks. Co-developed-by: Claude Code v2.1.90 (claude-sonnet-4-6)
Author
|
Closing for now — testing CI on fork first before submitting upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #435 (thanks @cr1901!) — the Makefile changes are rebased onto current master and the
_MSC_VERguards upstream already landed separately. Two additional fixes/additions:LIBS += -lshlwapi: Add Windows fixes so abc compiles natively with GCC. #435 used=(assignment) which would have overwritten all previously accumulated libs; changed to+=build-mingw.ymlCI workflow: uses MSYS2/MINGW64 onwindows-latestto actually verify the MinGW build path in CIChanges
Commit 1 — Makefile changes from #435:
MINGW%uname output toOS := MINGWfor clean conditionals-lrtand-ldlon MINGW (these don't exist on Windows)-lshlwapiforPathMatchSpecAused insclLiberty.c$(PROG).into GARBAGE for cleanupCommit 2 — CI:
build-mingw.yml: MSYS2/MINGW64,windows-latest,ABC_USE_STDINT_H=1,-DWIN32 -DWIN32_NO_DLLNote: the
WIN32→_MSC_VERchanges from #435 were not included — upstream already landed equivalentdefined(WIN32) && !defined(__MINGW32__)guards in cadical/kissat, which achieve the same result.Closes #435