Skip to content

feat: add monadics to library pages#167

Merged
JeffGarland merged 2 commits intomainfrom
msvetkin/feat/add-monadics-to-library-pages
May 5, 2026
Merged

feat: add monadics to library pages#167
JeffGarland merged 2 commits intomainfrom
msvetkin/feat/add-monadics-to-library-pages

Conversation

@msvetkin
Copy link
Copy Markdown
Contributor

@msvetkin msvetkin commented May 4, 2026

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for bemanproject ready!

Name Link
🔨 Latest commit 3db04b3
🔍 Latest deploy log https://app.netlify.com/projects/bemanproject/deploys/69f8bdc8abf7fa0008057aa7
😎 Deploy Preview https://deploy-preview-167--bemanproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@msvetkin msvetkin force-pushed the msvetkin/feat/add-monadics-to-library-pages branch from 0eefc3f to a248568 Compare May 4, 2026 14:45
@msvetkin msvetkin force-pushed the msvetkin/feat/add-monadics-to-library-pages branch from a248568 to f1468e2 Compare May 4, 2026 14:47
@msvetkin
Copy link
Copy Markdown
Contributor Author

msvetkin commented May 4, 2026

@neatudarius it looks like pre-commit check stuff unrelated to the PR.

@neatudarius
Copy link
Copy Markdown
Member

  • Lint Check (pre-commit) / pre-commit / Pre-Commit check on Push (push)

Is you fork up to date?

Copy link
Copy Markdown
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wait for one @bemanproject/project-leads to approve (when inserting a new library on website)

@msvetkin
Copy link
Copy Markdown
Contributor Author

msvetkin commented May 4, 2026

  • Lint Check (pre-commit) / pre-commit / Pre-Commit check on Push (push)

Is you fork up to date?

I have just cloned it, but it fails on CI and I have not touched those files.

@JeffGarland
Copy link
Copy Markdown
Member

I was having problems with the lint checks on my last PR as well

@vickgoodman
Copy link
Copy Markdown

vickgoodman commented May 5, 2026

As per @neatudarius' request, also added beman.monadics to Compiler Explorer:
compiler-explorer/compiler-explorer#8660

@msvetkin
Copy link
Copy Markdown
Contributor Author

msvetkin commented May 5, 2026

@JeffGarland if you want I can run all pre-commit checks and do a separate commit for that or it should be a separate PR?

@JeffGarland
Copy link
Copy Markdown
Member

I don't think we should try to fix the main issues in this PR. I'm going to merge this and we can open another issue.

@JeffGarland JeffGarland merged commit 33f1840 into main May 5, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants