Skip to content

fix(ci): bump rules_cc to 0.2.17 to unbreak RBE #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinpark1217 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

fix(ci): bump rules_cc to 0.2.17 to unbreak RBE #3788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ END_UNRELEASED_TEMPLATE
default to `true`.
* (pypi) The data files of a wheel (bin, includes, etc) are now always included
as a library's data dependencies.
* (deps/bzlmod) Bumped the bzlmod `rules_cc` dependency from `0.1.5` to
`0.2.17`. This is the minimum version exposing
`cc/toolchains:feature_injection.bzl`, which the BazelCI-injected
`buildkite_config//cc/cc_toolchain_config.bzl` now loads unconditionally
on RBE. The WORKSPACE `http_archive` pin is left at `0.1.5` because
`rules_cc` 0.2.17+ requires consumers to also call
`compatibility_proxy_repo()` in their WORKSPACE, which would be a
breaking change for existing users; WORKSPACE consumers don't use RBE
in this repo and aren't affected by the BazelCI change.

{#v0-0-0-fixed}
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ bazel_dep(name = "bazel_features", version = "1.21.0")
bazel_dep(name = "bazel_skylib", version = "1.8.2")
bazel_dep(name = "package_metadata", version = "0.0.7")
bazel_dep(name = "platforms", version = "0.0.11")
bazel_dep(name = "rules_cc", version = "0.1.5")
bazel_dep(name = "rules_cc", version = "0.2.17")

# Those are loaded only when using py_proto_library
# Use py_proto_library directly from protobuf repository
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/local_toolchains/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module(name = "module_under_test")
bazel_dep(name = "rules_python", version = "0.0.0")
bazel_dep(name = "bazel_skylib", version = "1.7.1")
bazel_dep(name = "platforms", version = "0.0.11")
bazel_dep(name = "rules_cc", version = "0.1.5")
bazel_dep(name = "rules_cc", version = "0.2.17")

local_path_override(
module_name = "rules_python",
Expand Down