fix: pip_compile: Forward target compatibility to *.update#3787
Open
castler wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies pip_compile.bzl to pass the target_compatible_with attribute to the .update target. Feedback indicates that using None as a default value for this attribute will trigger a Bazel type error, as a list is expected. Additionally, the reviewer suggested forwarding the testonly attribute to ensure the target remains compatible with its dependencies.
castler
force-pushed
the
target_compatible_with_for_pip_compile_update
branch
from
9b046e8 to
3620848
Compare
With this changset we enable users to build and test `//...` in their repositories also with platforms that do not support Python. For example, a user might use Python for tooling and automation, where he develops only on Linux. Then he could set `target_compatible_with` to `@platforms//os:linux`, but he uses C++ for his production code. Where he crosscompiles to other operating systems (e.g. QNX, TriCore). In order to enable this, we need to forward `target_compatible_with` also to the ` also to the also to the `*.update` target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this changset we enable users to build and test
//...in their repositories also with platforms that do not support Python.For example, a user might use Python for tooling and automation, where he develops only on Linux. Then he could set
target_compatible_withto@platforms//os:linux, but he uses C++ for his production code. Where he crosscompiles to other operating systems (e.g. QNX, TriCore).In order to enable this, we need to forward
target_compatible_withalso to thealso to the also to the*.update` target.