feat(gazelle): enable pyi attrs by default#3753
feat(gazelle): enable pyi attrs by default#3753amartani wants to merge 3 commits intobazel-contrib:mainfrom
Conversation
Default pyi_deps and pyi_srcs generation to true so generated targets preserve type-only dependencies and sibling stub files without extra directives.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default settings for the Gazelle Python extension, setting both python_generate_pyi_deps and python_generate_pyi_srcs to true by default. The documentation has been expanded with detailed usage examples for these directives, and the CHANGELOG.md and configuration code have been updated to reflect these changes. I have no feedback to provide.
Add `:versionchanged: VERSION_NEXT_FEATURE` for `python_generate_pyi_deps` and `python_generate_pyi_srcs` in directives documentation.
…ives Move `:versionchanged: VERSION_NEXT_FEATURE` blocks to immediately follow the `:versionadded:` sections for `python_generate_pyi_deps` and `python_generate_pyi_srcs`.
From my read of https://rules-python.readthedocs.io/en/latest/contributing.html#breaking-changes I'd expect this change to be fine, but let me know. |
2 participants
Default python_generate_pyi_deps and python_generate_pyi_srcs to true so generated targets preserve type-only dependencies and sibling stub files without extra directives. These directives have been available for many versions now, and defaulting to true better matches the intended semantics of current rules_python versions.
Write detailed docs for
python_generate_pyi_depssince that was missing.