Open
Conversation
Picks up basecamp/basecamp-sdk#207 which fixes update methods silently dropping empty ID slices. Previously, unassigning the last assignee/participant/subscriber had no effect because the SDK omitted the empty array from the request body.
github-actions
bot
added
sdk
There was a problem hiding this comment.
Pull request overview
Bumps the pinned github.com/basecamp/basecamp-sdk/go revision to pick up upstream handling for empty ID arrays ([]) vs nil, fixing “clear last assignee/participant” operations that previously resulted in no-op API requests.
Changes:
- Update
basecamp-sdktofe6154c8b320ingo.mod/go.sum. - Update embedded SDK provenance metadata (version, revision, updated timestamp).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/version/sdk-provenance.json | Updates embedded SDK provenance to the new SDK pseudo-version/revision. |
| go.mod | Bumps the basecamp-sdk dependency to the new pseudo-version. |
| go.sum | Updates checksums to match the new basecamp-sdk version. |
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basecamp-sdktofe6154c8b320to pick up Fix update methods silently dropping empty ID arrays basecamp-sdk#207basecamp unassignsilently failing when removing the last assignee from a todo, card, or card stepThe SDK previously used
len(slice) > 0to guard writing ID arrays into requests, which dropped empty slices ([]int64{}). The API interprets an absent field as "no change", so clearing the last assignee/participant had no effect. The SDK now usesnilchecks, preserving three-way semantics:nil= don't change,[]= clear all,[1,2]= set specific IDs.No CLI code changes needed — the fix is entirely in the SDK.
Ref: https://3.basecamp.com/2914079/buckets/46292715/card_tables/cards/9696883477
Summary by cubic
Upgrade
github.com/basecamp/basecamp-sdk/goto fix empty ID array handling. Unassigning and clearing participants now correctly removes the last IDs.Bug Fixes
basecamp unassignremoves the final assignee on todos, cards, and steps.Dependencies
github.com/basecamp/basecamp-sdk/goto include the empty ID array fix.Written for commit 5fbbfdc. Summary will update on new commits.