Skip to content

fix(middleware): avoid double slash in /flashblocks redirect#2974

Merged
xtbase merged 1 commit intobase:masterfrom
kinderjoypresents:flashblocks-redirect-fix
Mar 11, 2026
Merged

fix(middleware): avoid double slash in /flashblocks redirect#2974
xtbase merged 1 commit intobase:masterfrom
kinderjoypresents:flashblocks-redirect-fix

Conversation

@kinderjoypresents
Copy link
Contributor

What changed? Why?

Fixes /flashblocks redirect path construction to avoid producing URLs with double slashes.

Notes to reviewers

Previously, redirecting from /flashblocks/* could set url.pathname to //... because subPath already begins with /.
This change normalizes the pathname before redirecting.

How has it been tested?

Manually.

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

@vercel
Copy link

vercel bot commented Mar 5, 2026

@kinderjoypresents is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 5, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
base-web Ready Ready Preview, Comment Mar 11, 2026 4:13pm

Request Review

@xtbase xtbase merged commit 520aed2 into base:master Mar 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants