fix: align engine RPC protocols between mainnet and sepolia configs#1008
fix: align engine RPC protocols between mainnet and sepolia configs#1008
Conversation
.env.sepolia had swapped protocols introduced in base#985: - OP_NODE_L2_ENGINE_RPC was ws:// (should be http://, consistent with mainnet) - BASE_NODE_L2_ENGINE_RPC was http:// (should be ws://, required by base-consensus-entrypoint) The entrypoint script uses string substitution \\\ to derive the health-check URL, which only works correctly when the value starts with ws://. Using http:// causes the node to fail to start on Sepolia. Aligns Sepolia config with Mainnet which has the correct protocol assignments.
🟡 Heimdall Review Status
|
|
Friendly ping — this fix addresses a real issue where Sepolia nodes using base-consensus may fail to start due to the health-check URL derivation in base-consensus-entrypoint. Happy to make any adjustments if needed. |
|
Note: upstream was updated in #1001 (0ef36d3) which touched both env files but did not fix the protocol inconsistency. The bug is still present in upstream/main — .env.sepolia still has OP_NODE_L2_ENGINE_RPC=ws:// and BASE_NODE_L2_ENGINE_RPC=http:// which are inverted relative to mainnet and incompatible with the base-consensus-entrypoint health-check substitution. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still interested in getting this merged. This fix addresses a real configuration inconsistency between mainnet and sepolia engine RPC protocols that affects node operators. Happy to rebase on latest main and address any feedback. |
2 participants
Summary
Fixes a protocol inconsistency in
.env.sepoliaintroduced in #985, whereOP_NODE_L2_ENGINE_RPCandBASE_NODE_L2_ENGINE_RPChad their protocols swapped compared to.env.mainnet.Root Cause
In commit
e684286(PR #985), the newBASE_NODE_*variables were added to both env files, but with inverted protocols:OP_NODE_L2_ENGINE_RPChttp://ws://❌http://✅BASE_NODE_L2_ENGINE_RPCws://http://❌ws://✅Why This Matters
The
base-consensus-entrypointscript derives the health-check URL using bash string substitution:This substitution only works correctly when
BASE_NODE_L2_ENGINE_RPCstarts withws://. When set tohttp://, the replacement produces no change and the health-check hits the wrong endpoint, preventing the Sepolia node from starting correctly.Changes
.env.sepolia:OP_NODE_L2_ENGINE_RPCws://→http://.env.sepolia:BASE_NODE_L2_ENGINE_RPChttp://→ws://No changes to
.env.mainnet(already correct).