Skip to content

Feat/gh issues forallkinds#7941

Merged
Rugvip merged 3 commits intobackstage:mainfrom
PadreSVK:feat/gh-issues-forallkinds
Mar 24, 2026
Merged

Feat/gh issues forallkinds#7941
Rugvip merged 3 commits intobackstage:mainfrom
PadreSVK:feat/gh-issues-forallkinds

Conversation

@PadreSVK
Copy link
Copy Markdown
Contributor

@PadreSVK PadreSVK commented Mar 4, 2026

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

#7462

@backstage-goalie
Copy link
Copy Markdown
Contributor

backstage-goalie Bot commented Mar 4, 2026

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-github-issues workspaces/github/plugins/github-issues minor v0.19.1

@backstage-goalie
Copy link
Copy Markdown
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Patrik Švikruha added 3 commits March 5, 2026 06:47
Signed-off-by: Patrik Švikruha <patrik.svikruha.dev@gmail.com>
…inds

Signed-off-by: Patrik Švikruha <patrik.svikruha.dev@gmail.com>
Signed-off-by: Patrik Švikruha <patrik.svikruha.dev@gmail.com>
@PadreSVK PadreSVK force-pushed the feat/gh-issues-forallkinds branch from 52c4552 to 12300c1 Compare March 5, 2026 05:48
@PadreSVK
Copy link
Copy Markdown
Contributor Author

PadreSVK commented Mar 5, 2026

image

});
const repositoryEntities: Repository[] = [];
// For Group and User entities fetch owned components and retrieve all issues
if (entity.kind === 'Group' || entity.kind === 'User') {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking, what if we remove the if else and execute the two operations regardless?

something like this:

  const repositoryEntities =  (await catalogApi.getEntities({
      filter: {
        'relations.ownedBy': stringifyEntityRef(entity),
      },
    }).map(blablabla);
   
  const entityName = getProjectNameFromEntity(entity);
  const locationHostname = getHostnameFromEntity(entity);
  if (entityName) {
      repositoryEntities.push({
         name: entityName,
         locationHostname,
      });
  }

Or is the check Component/API vs Group/User needed for some reason?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current logic is:

If User/Group View, get all Entities that have relation ownedBy to User/Group* and get all repositories (based on https://backstage.io/docs/features/software-catalog/well-known-annotations/#githubcomteam-slug annotation.)

For all other kinds, just extract https://backstage.io/docs/features/software-catalog/well-known-annotations/#githubcomteam-slug. For other types does not make sense to search for ownedBy relation as is related only to Group and User

*for now it works only for Group and User - it does not solve transitive dependency => User is part of Group that owns Entity) => this could be also enhanced as User view show on card all transitive (Groups) "ownedBy" entities.

Copy link
Copy Markdown
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🎉

@Rugvip Rugvip merged commit 4f8c80c into backstage:main Mar 24, 2026
12 checks passed
evanlankveld pushed a commit to evanlankveld/community-plugins that referenced this pull request Apr 28, 2026
* feat: add support for all kinds

Signed-off-by: Patrik Švikruha <patrik.svikruha.dev@gmail.com>

* doc: enhance README to clarify plugin behavior for different Entity kinds

Signed-off-by: Patrik Švikruha <patrik.svikruha.dev@gmail.com>

* chore: add changelog

Signed-off-by: Patrik Švikruha <patrik.svikruha.dev@gmail.com>

---------

Signed-off-by: Patrik Švikruha <patrik.svikruha.dev@gmail.com>
Co-authored-by: Patrik Švikruha <patrik.svikruha.dev@gmail.com>
Signed-off-by: Emiel van Lankveld <evanlankveld@bol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants