feat(sdk): Add DurableInstrumentationPlugin interface and plugin runner#408
Open
ayushiahjolia wants to merge 1 commit into
Open
feat(sdk): Add DurableInstrumentationPlugin interface and plugin runner#408ayushiahjolia wants to merge 1 commit into
ayushiahjolia wants to merge 1 commit into
Conversation
ayushiahjolia
force-pushed
the
plugin-interface
branch
from
c33efc2 to
8ae3d93
Compare
SilanHe
reviewed
May 27, 2026
| * @param outcome the attempt outcome (SUCCEEDED, FAILED, or RETRYING) | ||
| * @param error non-null if the attempt failed | ||
| * @param nextAttemptDelaySeconds non-null if outcome is RETRYING | ||
| * @experimental This record is experimental and may be changed or removed in future releases. |
Contributor
There was a problem hiding this comment.
I'm not sure this tag actually exists in Javadoc, I think people use @deprecated instead with an explanation that it's experimental.
SilanHe
reviewed
May 27, 2026
| chain = () -> { | ||
| try { | ||
| return hookExtractor.apply(plugin).apply(next); | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
I updated the JS runAsCallback as follows: https://github.com/aws/aws-durable-execution-sdk-js/blob/bcea797ed2ba70949b1b755f6b92064705ad2cb3/packages/aws-durable-execution-sdk-js/src/utils/plugin/plugin-runner.ts#L21
it will not swallow the errors in the customer provided function but it swallows the plugin exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#364
Description
Introduce the plugin system foundation for the durable execution SDK:
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? N/A
Integration Tests
Have integration tests been written for these changes? N/A
Examples
Has a new example been added for the change? (if applicable) N/A