fix: raise lxml upper bound to <7.0.0#275
Open
chris-lumi-ai wants to merge 1 commit intoaws:masterfrom
Open
Conversation
lxml 6.0 support was already validated (see TestLxmlCurlyBraceCompatibility). lxml 6.1 introduces no breaking changes for this package: all lxml usage goes through BeautifulSoup4, which abstracts the parser API, and none of the deprecated/removed lxml 6.x APIs (setElementClassLookup, apply, evaluate, MemDebug, text_content smart strings) are called directly. Bumping the cap from <=6.0.2 to <7.0.0 unblocks downstream users who need lxml 6.1.0+ to address CVE-2026-41066.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raises the
lxmlupper bound inrequirements.txtfrom<=6.0.2to<7.0.0.Motivation and Context
lxml 6.1.0 addresses CVE-2026-41066 (XXE via changed
resolve_entitiesdefault initerparse/ETCompatXMLParser). The current<=6.0.2cap prevents downstream users from taking that security fix.lxml 6.0 support was already validated in this repo (see
TestLxmlCurlyBraceCompatibilityintest/unit/plugin/test_adfs_credentials_provider.py). lxml 6.1.0 introduces no breaking changes for this package because all lxml usage flows through BeautifulSoup4, which abstracts the parser API entirely:adfs_credentials_provider.py—bs4.BeautifulSoup(response.text, features="lxml")saml_credentials_provider.py—bs4.BeautifulSoup(doc, "xml")ping_credentials_provider.py—bs4.BeautifulSoup(response.text)None of the removed or changed lxml 6.x APIs are called directly (
setElementClassLookup,apply,evaluate,MemDebug, smart-stringtext_content,iterparseentity resolution default). BeautifulSoup4 isolates all of that. Raising the cap to<7.0.0unblocks the upgrade path while matching the approach already taken for lxml 6.0.Testing
No code paths were changed — only the declared version constraint. The existing
TestLxmlCurlyBraceCompatibilitytest class already covers lxml 6.x + BeautifulSoup4 compatibility for the ADFS provider. All existing unit tests pass unchanged with lxml 6.1.0 installed.Screenshots
N/A
Types of changes
Checklist
./build.shsucceedspre-commit run --files requirements.txt— clean; pre-existing hook failures exist in untouched files)TestLxmlCurlyBraceCompatibilitycovers lxml 6.x compatibility)pytest test/unitand they are passingBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.